Skip to content

Release Proposal: v2.14#556

Merged
mattmcneeney merged 1 commit intocloudfoundry:masterfrom
mattmcneeney:v2.14-rc
Jul 24, 2018
Merged

Release Proposal: v2.14#556
mattmcneeney merged 1 commit intocloudfoundry:masterfrom
mattmcneeney:v2.14-rc

Conversation

@mattmcneeney
Copy link
Contributor

@mattmcneeney mattmcneeney commented Jul 17, 2018

Announcing a new release candidate as described in the Release Process.

Release version: v2.14
Release SHA: a233c97
Target release date: 2018-07-24

The one-week Review Process will be triggered on the next weekly call.

@cfdreddbot
Copy link

Hey mattmcneeney!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@mattmcneeney mattmcneeney self-assigned this Jul 17, 2018
@mattmcneeney mattmcneeney requested a review from a team July 17, 2018 10:31
@fmui
Copy link
Contributor

fmui commented Jul 23, 2018

The ToC contains a link to the 2.12 changes section ([Changes Since v2.12](#changes-since-v212)), which should be a 2.13 changes section now.

@mattmcneeney
Copy link
Contributor Author

Thanks @fmui ! Fixed.

Reminder: The one week review deadline for this is tomorrow!
cc @openservicebrokerapi/osbapi-pmc

application/json:
schema:
$ref: '#/components/schemas/ServiceInstanceAsyncProvision'
$ref: '#/components/schemas/ServiceInstanceAsyncOperation'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these changes part of this PR and not part of some other PR? Were they just missed or is there something in the release process that causes these changes to only happen now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were missed as those PRs were created before we had these openAPI docs. From now on, all PRs that change the API behaviour should also include changes to both docs before we approve them!

@duglin
Copy link
Contributor

duglin commented Jul 24, 2018

LGTM

Approved with PullApprove

1 similar comment
@fmui
Copy link
Contributor

fmui commented Jul 24, 2018

LGTM

Approved with PullApprove

@pmorie
Copy link
Contributor

pmorie commented Jul 24, 2018

Lgtm

Looks like travis is broken?

Approved with PullApprove

@mattmcneeney
Copy link
Contributor Author

@pmorie it's always broken when we do releases, since the changes contain URLs that don't exist yet!

@mattmcneeney
Copy link
Contributor Author

mattmcneeney commented Jul 24, 2018

A release proposal requires at least 4 "LGTM" comments from at least 4 different organizations to be approved.

This release candidate has been open now for more than one week and has the required LGTMs. I will now merge this and follow the rest of the release process!

Approved with PullApprove

@mattmcneeney mattmcneeney merged commit 12ea7fb into cloudfoundry:master Jul 24, 2018
@mattmcneeney mattmcneeney deleted the v2.14-rc branch July 24, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants