fixed Originating Identity example#559
Conversation
|
Hey fmui! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
mattmcneeney
left a comment
There was a problem hiding this comment.
None of the fields in the Originating Identity Header section of the profile describes a key named user_name. Did you mean username as described in the Kuberenetes section?
|
hmm the example is a CF one, so perhaps we need to drop that user_name field from the encoding? Does CF have a user_name field? |
|
@duglin Not according to the profiles (and not that I know of!) |
|
@mattmcneeney If you decode the base64 string that is in the spec today, the JSON contains the field "user_name". We could either don't touch the base64 string and use "user_name" or we change the base64 string and JSON to something else. |
|
Interesting @fmui - I didn't know that! Can we use this PR to add that to the profile doc as well? |
|
It looks like the docs are wrong to me @fmui. At least in CC we only send So it looks like the base64 hash is infact wrong. |
|
I've changed the base64 strings. |
The decoded value of the Originating Identity example also contains a "user_name" entry.