GET instance/bindings MAY not return parameters#562
Merged
n3wscott merged 1 commit intocloudfoundry:masterfrom Jul 31, 2018
Merged
GET instance/bindings MAY not return parameters#562n3wscott merged 1 commit intocloudfoundry:masterfrom
n3wscott merged 1 commit intocloudfoundry:masterfrom
Conversation
|
Hey jberkhahn! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Contributor
|
Hey @jberkhahn - what was the reasoning behind making this more explicit? |
Contributor
|
We got some questions from our folks about whether or not they were allowed to exclude sensitive info passed as parameters. They didn't want to violate the spec by not returning all params if that's what the spec was mandating. |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
mattmcneeney
approved these changes
Jul 31, 2018
|
lgtm |
n3wscott
approved these changes
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just making this explicit.