Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception thrown when creating new space #2564

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Fix exception thrown when creating new space #2564

merged 1 commit into from
Jun 28, 2018

Conversation

richard-cox
Copy link
Contributor

  • Start session at CF summary
  • Nav to orgs tab --> org --> org spaces tab
  • Create space
  • The allApps observable from the cf service was receiving a partial entity that did not yet have apps
  • Fixes Exception thrown when creating space #2560

@richard-cox
Fix exception thrown when creating new space
3e94cfe 
- Start session at CF summary
- Nav to orgs tab --> org --» org spaces tab
- Create space
- The allApps observable from the cf summary page was receiving a partial entity that did not yet have apps
@richard-cox richard-cox self-assigned this Jun 28, 2018
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #2564 into v2-master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           v2-master    #2564   +/-   ##
==========================================
  Coverage      70.42%   70.42%           
==========================================
  Files            594      594           
  Lines          25135    25135           
  Branches        5674     5675    +1     
==========================================
  Hits           17701    17701           
  Misses          7434     7434

nwmac
nwmac approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 539944b into v2-master Jun 28, 2018
@nwmac nwmac deleted the fix-exception-on-new-space branch June 28, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac