Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send username/password in the URL #3771

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Aug 15, 2019

Fixes #3160

@nwmac nwmac self-assigned this Aug 15, 2019
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #3771 into v2-master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##           v2-master    #3771      +/-   ##
=============================================
- Coverage      52.17%   52.16%   -0.02%     
=============================================
  Files            783      783              
  Lines          22892    22899       +7     
  Branches        4088     4089       +1     
=============================================
  Hits           11945    11945              
- Misses         10947    10954       +7

@richard-cox richard-cox merged commit b033a5b into v2-master Aug 16, 2019
@richard-cox richard-cox deleted the auth-values-in-body branch August 16, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint login exposes user credentials via query string
3 participants