Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure stepper buttons are always visible and content scrolls #3890

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Sep 20, 2019

No description provided.

@nwmac nwmac self-assigned this Sep 20, 2019
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #3890 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #3890   +/-   ##
==========================================
  Coverage      52.22%   52.22%           
==========================================
  Files            785      785           
  Lines          23010    23010           
  Branches        4124     4124           
==========================================
  Hits           12016    12016           
  Misses         10994    10994

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with lots of interesting steppers, all fine. LGTM

@nwmac nwmac merged commit 8cd1aa6 into v2-master Sep 22, 2019
@nwmac nwmac deleted the fix-stepper-sticky-buttons branch September 22, 2019 22:46
KlapTrap added a commit that referenced this pull request Sep 23, 2019
* v2-master:
  Add support for view and edit profile for local user (#3883)
  Add fix to wait until delete indicator has been removed (#3889)
  FIx setup detection for local users (#3888)
  Ensure stepper buttons are always visible and content scrolls (#3890)
  E2E Test should run as user not admin (#3894)
KlapTrap added a commit that referenced this pull request Sep 25, 2019
* v3-master:
  Fix cf summary unit test failures - cf now has dependency on autoscaler - see #3916
  catalogue: fixed initial state that was overwritten
  Travis: Build once and share build in e2e tests (#3901)
  Improve user clean up
  Ensure MB is only shown for memory based quota values in edit quota forms (#3892)
  Fix domains in create app shell stepper
  Fix git commit world
  WIP
  Fix two actionBuilder params issues - Fix three places where `includeRelations` were passed incorrectly to actionBuilder - Fix bind service
  Ensure multi endpoint requests only go out to connected/unconnectable endpoints - Fixes #3887
  Travis: Build once and share build in e2e tests (#3901)
  Improve user clean up
  Ensure MB is only shown for memory based quota values in edit quota forms (#3892)
  Add support for view and edit profile for local user (#3883)
  Add fix to wait until delete indicator has been removed (#3889)
  FIx setup detection for local users (#3888)
  Ensure stepper buttons are always visible and content scrolls (#3890)
  E2E Test should run as user not admin (#3894)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants