Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug info for manage users e2e tests #3938

Merged
merged 6 commits into from
Oct 3, 2019
Merged

Conversation

richard-cox
Copy link
Contributor

  • Add commented out feature to throttle protractor tests
  • Add debug comments to create/delete cf/uaa users
  • Add error comments to uaa calls

- Add commented out feature to throttle protractor tests
- Add debug comments to create/delete cf/uaa users
- Add error comments to uaa calls
@richard-cox richard-cox self-assigned this Oct 1, 2019
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #3938 into v2-master will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #3938      +/-   ##
=============================================
- Coverage      52.22%   52.21%   -0.01%     
=============================================
  Files            785      785              
  Lines          23017    23017              
  Branches        4124     4124              
=============================================
- Hits           12020    12019       -1     
- Misses         10997    10998       +1

- seeing similar behaviour for other failing tests
- first failure is roughly 55 seconds following quickly by rest of tests
- all tests fail with default timeout
- this seems to be due to beforeAll timing out
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit ff3c42f into v2-master Oct 3, 2019
@nwmac nwmac deleted the e2e-user-debugging branch October 3, 2019 07:45
KlapTrap added a commit that referenced this pull request Oct 9, 2019
* v3-master:
  Fix lint & unit tests
  Fix connect to endpoint subtype
  Ensure we're passing the correct params to action builders.
  Removed console logs
  Ensure endpoint register tiles are ordered correctly
  Start with empty CustomizationsMetadata
  Convert CustomizationsMetadata inject into singleton CustomizationService
  Fix npm audit vulnerabilities (#3899)
  Remove old ingress docs and add new (#3961)
  Helm Chart: Add ingress support (#3935)
  Fix liniting
  unit tests: added more tests for components and utils
  Merge pull request #3939 from cloudfoundry-incubator/mysqldb-dev
  Gate SSO redirect on optional state whitelist (#3933)
  Add debug info for manage users e2e tests (#3938)
  Fix metrics issue with multiple k8s endpoints
  Fix non jetstream requests and other, minor fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants