Fix long running service actions #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Dec 5, 2019
richard-cox
commented
- Depends on Backend changes to support long-running requests #4043 and Show last operation and service broker info for service instances #4038
- Some brokers take a long time to execute create, update and delete service instance operations
- This time exceeded the amount allowed by browser/jetstream
- We now provide a custom response to the front end when this happens
- Front end then handles this and also shows a custom error message
…ong-running-service-actions
- sometimes these are fetched inline which aren't sorted
- Some brokers take a long time to execute create, update and delete service instance operations - This time exceeded the amount allowed by browser/jetstream - We now provide a custom response to the front end when this happens - Front end then handles this and also shows a custom error message
- Use a common way to get a service name, service link, broker name - Split out cf specific long running functionality - Show service as a link in app service instance card - Show service plan and broker in app service instance card - Update the service instance entity on Update as well as Delete (will show a better 'last operation' value)
Codecov Report
@@ Coverage Diff @@
## v2-master #4049 +/- ##
=============================================
- Coverage 52.21% 52.21% -0.01%
=============================================
Files 787 790 +3
Lines 23080 23131 +51
Branches 4128 4133 +5
=============================================
+ Hits 12051 12077 +26
- Misses 11029 11054 +25 |
nwmac
approved these changes
Jan 6, 2020
nwmac
added a commit
that referenced
this pull request
Jan 24, 2020
* Follow redirect - needed for repo move * Update metric used for cells (#4009) - `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed` - Try new metric first and fall back on old * Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015) - affects db migration of console config table to new config table - fixes #4013 * 2.6.1 Release preparation * Ingress fix (#4024) * Fixes ingress and kube 1.16 version issue * Update Changelog * More test * Fix ingress tests * Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039) * Backend changs to support long-running requests * Fix helm chart issue with semver (#4046) * Show last operation and service broker info for service instances (#4038) * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Fix create service instance from service instance page * Fix unit tests * Fix failing e2e test * Fix chrome driver version (#4078) * Fix long running service actions (#4049) * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Fix create service instance from service instance page * Fix unit tests * Ensure service plans are sorted by display name - sometimes these are fetched inline which aren't sorted * Handle Long Running Service Instance Operations - Some brokers take a long time to execute create, update and delete service instance operations - This time exceeded the amount allowed by browser/jetstream - We now provide a custom response to the front end when this happens - Front end then handles this and also shows a custom error message * Changes and tidy up post review - Use a common way to get a service name, service link, broker name - Split out cf specific long running functionality - Show service as a link in app service instance card - Show service plan and broker in app service instance card - Update the service instance entity on Update as well as Delete (will show a better 'last operation' value) * Fix failing unit tests * Fix failing e2e test * Fix bad merge * Fixes following merge * Fix table cell active/bindable icons * Remove incorrectly merged file * Fix message for long running delete service instance * Fix service market place list bug where user provided services didn't show * Remove dupe file Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Guillaume Berche <guillaume.berche@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.