Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transition from space summary to app summary page #4320

Merged
merged 5 commits into from
Jun 2, 2020
Merged

Fix transition from space summary to app summary page #4320

merged 5 commits into from
Jun 2, 2020

Conversation

richard-cox
Copy link
Contributor

  • bug came in after entity access work (we now use the entity service factory everywhere)
  • an entity service for a space with no org was cached by guid
  • an entity service for a space requiring org used the space with no org cached version
  • solution is to make cache id include schema key (determines with/without org)
  • also tidied use of rootUpdatingKey and added comment regarding blocking validating entities

@richard-cox
Fix transition from space summary to app summary page
5093799 
- an entity service for a space with no org was cached by guid
- an entity service for a space requiring org used cached version
- solution is to make cache id include schema key (determines with/without org)
@richard-cox
Add comment, tidy up rootUpdatingKey
ac762cd
@richard-cox richard-cox self-assigned this May 28, 2020
nwmac
nwmac approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge when gates pass

@richard-cox richard-cox merged commit 8e08234 into master Jun 2, 2020
@richard-cox richard-cox deleted the entity-service-fixes branch June 2, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
bug ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac