Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where default add/remove setting in change role by username was incorrect #4334

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

richard-cox
Copy link
Contributor

  • came in with angular 9 PR
  • add/remove radio button default value governed by add/remove feature flags
  • when one is set to false the radio button should be disabled and the other selected

… was incorrect

- add/remove radio button default value governed by add/remove feature flags
- when one is set to false the radio button should be disabled and the other selected
@richard-cox richard-cox self-assigned this May 29, 2020
@nwmac nwmac self-requested a review June 2, 2020 10:07
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit c3bcc93 into master Jun 3, 2020
@richard-cox richard-cox deleted the fix-add-remove-role-by-username branch June 3, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants