Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more store -> core dependencies #4379

Merged
merged 17 commits into from
Jun 18, 2020
Merged

Remove more store -> core dependencies #4379

merged 17 commits into from
Jun 18, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 18, 2020

Removes references to:

  • LoggerService
  • environment

@nwmac nwmac self-assigned this Jun 18, 2020
@richard-cox richard-cox added needs attention This PR needs attention conflicts Merge conflicts on PR labels Jun 18, 2020
@nwmac nwmac removed conflicts Merge conflicts on PR needs attention This PR needs attention labels Jun 18, 2020
@richard-cox richard-cox merged commit f1b99b0 into master Jun 18, 2020
@richard-cox richard-cox deleted the store-core-2 branch June 18, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwmac @richard-cox