Post jwt token library refactoring #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
strehle
commented
Jan 12, 2024
•
strehle
commented
- remove string serialization and simplify token creation. create a JWT from a map instead of a string
- reduce complexity in token creation (map to string, then string to JWT)
- reduce complexity in token read (only once)
- remove and simplify token creation. Only from map instead of a string - reduce complexity in token creation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186832950 The labels on this github issue will be updated when the story is started. |
model/src/test/java/org/cloudfoundry/identity/uaa/oauth/token/IntrospectionClaimsTest.java
Outdated
Show resolved
Hide resolved
hsinn0
reviewed
Jan 18, 2024
model/src/main/java/org/cloudfoundry/identity/uaa/oauth/token/Claims.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/oauth/openid/IdToken.java
Outdated
Show resolved
Hide resolved
hsinn0
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.