Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore failing integration test" #2731

Merged

Conversation

peterhaochen47
Copy link
Member

This reverts commit 3f89139.

  • this test is passing; we shouldn't ignore valid tests on develop branch (or in branches we intend to release)

This reverts commit 3f89139.

- this test is passing; we shouldn't ignore valid tests
on develop branch (or in branches we intend to release)
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187057391

The labels on this github issue will be updated when the story is started.

@peterhaochen47 peterhaochen47 marked this pull request as ready for review February 15, 2024 23:30
Copy link
Contributor

@swalchemist swalchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, the combination of org.junit.Test with org.junit.jupiter.api.extension.ExtendWith is a concern - mixing jUnit4 and jUnit5 libraries can be problematic.

@peterhaochen47 peterhaochen47 merged commit 27afe2c into develop Feb 16, 2024
20 checks passed
@peterhaochen47 peterhaochen47 deleted the pr/develop/un-ignore-invitedOIDCUserVerified branch February 16, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants