Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support own key and cert for jwtClientAuthentication #2771

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Support own key and cert for jwtClientAuthentication #2771

merged 7 commits into from
Mar 25, 2024

Conversation

strehle
Copy link
Member

@strehle strehle commented Mar 7, 2024 •
edited
Loading

Load key, cert, alg
Support reference loading

Spec JwtClientAuthentication-PR2771.pdf

@strehle
Load key, cert, alg
4d255f9 
Support reference loading
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187195296

The labels on this github issue will be updated when the story is started.

strehle added 2 commits March 8, 2024 09:53
@strehle
refactor load of keyinfo
52b1b71 
load application environment only within uaa zone
@strehle
Add documentation
09edae6
@strehle strehle linked an issue Mar 8, 2024 that may be closed by this pull request
Support reuse of OIDC identity provider configuration jwtClientAuthentication on a global level #2752
Closed
@strehle
Copy link
Member Author

strehle commented Mar 8, 2024

current doc
image

@strehle strehle requested review from peterhaochen47, torsten-sap and a team March 18, 2024 14:08
@strehle
Copy link
Member Author

strehle commented Mar 18, 2024

JwtClientAuthentication-PR2771.pdf

@strehle
Copy link
Member Author

strehle commented Mar 18, 2024

sonar:

https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2771

@Tallicia Tallicia self-requested a review March 18, 2024 20:55
@strehle strehle added this to the feature - private_key_jwt milestone Mar 19, 2024
@strehle
Copy link
Member Author

strehle commented Mar 20, 2024

@peterhaochen47 would be great if you could find time to see if this PR here is ok for you.

We will try it then in your SAP staging area if all assumptions are true

@peterhaochen47
Copy link
Member

peterhaochen47 commented Mar 20, 2024 •
edited by strehle
Loading

@peterhaochen47 would be great if you could find time to see if this PR here is ok for you.

We will try it then in our SAP staging area if all assumptions are true

@Tallicia is looking at this PR.

@strehle
Copy link
Member Author

strehle commented Mar 20, 2024

@Tallicia is looking at this PR.

ok thanks . If you have questions we can discuss either tomorrow or you ask in slack/here in PR

Tallicia
Tallicia approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is acceptable, though there are some questions and addressing the warning suppression and java doc consistency would be good followups.

server/src/main/java/org/cloudfoundry/identity/uaa/oauth/jwt/JwtClientAuthentication.java Show resolved Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/oauth/jwt/JwtClientAuthentication.java Outdated Show resolved Hide resolved
server/src/test/java/org/cloudfoundry/identity/uaa/oauth/jwt/JwtClientAuthenticationTest.java Show resolved Hide resolved
...src/test/java/org/cloudfoundry/identity/uaa/mock/providers/IdentityProviderEndpointDocs.java Outdated Show resolved Hide resolved
@Tallicia Tallicia added accepted Accepted the issue clarification needed The issue is not accepted but we need clarification and removed unscheduled labels Mar 21, 2024
@strehle strehle mentioned this pull request Mar 23, 2024
Merged
@strehle
Copy link
Member Author

strehle commented Mar 23, 2024

Doc

image

@strehle strehle merged commit 0da7548 into develop Mar 25, 2024
20 checks passed
@strehle strehle deleted the feat/jwtClientAuthentication/loadKeyByRef branch March 25, 2024 13:22
@cf-gitbot cf-gitbot removed in progress accepted Accepted the issue labels Mar 25, 2024
@torsten-sap torsten-sap mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tallicia Tallicia Tallicia approved these changes

@peterhaochen47 peterhaochen47 Awaiting requested review from peterhaochen47

@torsten-sap torsten-sap Awaiting requested review from torsten-sap

Assignees
No one assigned
Labels
clarification needed The issue is not accepted but we need clarification
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
feature - private_key_jwt
Development

Successfully merging this pull request may close these issues.

Support reuse of OIDC identity provider configuration jwtClientAuthentication on a global level
4 participants
@strehle @cf-gitbot @peterhaochen47 @Tallicia