-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests for EntityAliasHandler.ensureConsistencyOfAliasEntity #2824
Merged
adrianhoelzl-sap
merged 20 commits into
develop
from
refactor-tests-for-entityaliashandler-ensureconsistency
Apr 17, 2024
Merged
Refactor tests for EntityAliasHandler.ensureConsistencyOfAliasEntity #2824
adrianhoelzl-sap
merged 20 commits into
develop
from
refactor-tests-for-entityaliashandler-ensureconsistency
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… alias and alias feature enabled/disabled
…ature and existing/non-existing alias
…liasZidSetButZoneDoesNotExist' to superclass
…tingEntityHasAlias' to superclass
…enIfNoAliasPropertyIsChanged' to superclass
…erencedAliasIdpAndAliasZoneDoNotExist' to superclass
…WhenAliasZidSet' to test superclass
…NewAliasEntity_WhenAliasZoneExistsAndAliasPropertiesAreSet' to test superclass
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187413805 The labels on this github issue will be updated when the story is started. |
strehle
approved these changes
Apr 12, 2024
peterhaochen47
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #2505
Preparation for #2769; adds superclass to existing unit test class for IdentityProviderAliasHandler that can be re-used for the ScimUserAliasHandler.