fix: MySQL Performance Issues in "/ids/Users" Endpoint #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2ffb7af.
…JdbcScimUserProvisioning.retrieveByScimFilterOnlyActive
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187523764 The labels on this github issue will be updated when the story is started. |
|
Running through tests and this should be ready to merge once we get word back from Daniel and David. |
Tallicia
approved these changes
Apr 30, 2024
| @@ -31,6 +31,7 @@ | |||
| <property name="deactivateOnDelete" value="${scim.delete.deactivate:false}"/> | |||
| <property name="usernamePattern" value="${scim.username_pattern:[\p{L}+0-9+\-_.@'!]+}"/> | |||
| <property name="timeService" ref="timeService"/> | |||
| <property name="useCaseInsensitiveQueries" ref="useCaseInsensitiveQueries"/> | |||
|
|
||
| // build WHERE clause | ||
| final ProcessedFilter where = queryConverter.convert(filter, sortBy, ascending, zoneId); | ||
| final String whereClauseScimFilter = where.getSql(); |
There was a problem hiding this comment.
I believe this is where the many parens and ORs are generated, this should be looked at to refactor to use an IN clause.
There was a problem hiding this comment.
I was surprised to see that the deep nesting has been there a long time, and wasn't the cause of the performance degradation. But still it would be much easier to read the SQL without all the nesting.
| } | ||
|
|
||
| private static void addIdentityProvider(JdbcTemplate jdbcTemplate, String idzId, String originKey, boolean active) { | ||
| jdbcTemplate.update("insert into identity_provider (id,identity_zone_id,name,origin_key,type,active) values (?,?,?,?,'UNKNOWN',?)", UUID.randomUUID().toString(), idzId, originKey, originKey, active); |
Tallicia
added
in progress
accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #2856