-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Components, Combos, and Utilities from Blog Prototype #163
Conversation
@@ -0,0 +1,12 @@ | |||
@import "suitcss-components-arrange"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using arrange instead of .Grid
or .u-flex-*
?
*/ | ||
|
||
.u-textBold { | ||
font-weight: bold !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a variable for font weights?
@erikjung This is a big PR... I apologize for the avalanche of comments! I think I answered your |
Nothing to add, @tylersticka did a good job of combing through this PR. I did pick up a few details that I'll be using, so thank you @erikjung! 😀 Should be good to go after addressing any outstanding comments. 👍 |
This will be replaced by border utils in another PR
@tylersticka I've made changes based on your feedback. I'd rather resolve the |
LGTM! 👍 |
Left behind after CSS component did not make it for #163
This is a big PR, sorry.
Overview
.Figure
component pattern.List
component patternDeferred for later
FootnoteLink
component appearance #160)Questions
.List
component encroaches on.u-list*
utility territory. How do you think we should handle the collision of these two things?Blog combos
Form combos
New components
/CC @nicolemors @tylersticka @mrgerardorodriguez @saralohr