Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Components, Combos, and Utilities from Blog Prototype #163

Merged
merged 37 commits into from
May 2, 2016

Conversation

erikjung
Copy link
Contributor

This is a big PR, sorry.

Overview

  • Added a "combo" pattern section for UI specific to blog posts (based on @nicolemors prototype)
  • Added a "combo" pattern section for forms (just the comment form for now)
  • Added a new .Figure component pattern
  • Added a new .List component pattern
  • Added a handful of SUIT utilities
  • Added a handful of custom utilities

Deferred for later

Questions

  • @tylersticka The .List component encroaches on .u-list* utility territory. How do you think we should handle the collision of these two things?

Blog combos

screen shot 2016-04-29 at 3 21 33 pm

Form combos

screen shot 2016-04-29 at 3 22 01 pm

New components

screen shot 2016-04-29 at 3 21 12 pm
screen shot 2016-04-29 at 3 21 05 pm

/CC @nicolemors @tylersticka @mrgerardorodriguez @saralohr

@@ -0,0 +1,12 @@
@import "suitcss-components-arrange";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using arrange instead of .Grid or .u-flex-*?

*/

.u-textBold {
font-weight: bold !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a variable for font weights?

@tylersticka
Copy link
Member

tylersticka commented Apr 29, 2016

@erikjung This is a big PR... I apologize for the avalanche of comments!

I think I answered your .List question inline, but if I've missed anything, please let me know. Also happy to chat through stuff in person on Monday if I've thoroughly confused things.

@gerardo-rodriguez
Copy link
Member

Nothing to add, @tylersticka did a good job of combing through this PR. I did pick up a few details that I'll be using, so thank you @erikjung! 😀 Should be good to go after addressing any outstanding comments. 👍

@erikjung
Copy link
Contributor Author

erikjung commented May 2, 2016

@tylersticka I've made changes based on your feedback.

I'd rather resolve the .List/.Group/.u-border issue in another PR because I'm realizing now that it's substantial enough to not include here.

@tylersticka
Copy link
Member

LGTM! 👍

@erikjung erikjung merged commit 329b4d7 into master May 2, 2016
@erikjung erikjung deleted the feat-new_components_from_blog branch May 2, 2016 18:57
tylersticka added a commit that referenced this pull request May 19, 2016
Left behind after CSS component did not make it for #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants