Clickable, iframe-based thumbnail pattern for page/demo indices #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clickable, iframe-based thumbnails (`FrameThumb`)
|
Sweet! 👍 |
| </div> | ||
| </div> | ||
| <div class="drizzle-Grid-cell drizzle-u-md-size2of3"> | ||
| <div class="drizzle-u-marginEnds"> |
There was a problem hiding this comment.
This reminds me of something that slipped through...
Since this piece of UI seems to occur often, we should have a partial for it: https://github.com/cloudfour/cloudfour.com-patterns/blob/master/src/templates/drizzle/labelheader.hbs
|
Clever solution! Regarding my comment about the partial, we can also do that later if you want to make an issue for it. LGTM 👍 |
I agree with this feedback and started implementing it, but ran into an immediate snag or two. I'll definitely make an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
page-itempartial, which leverages a newFrameThumbpattern. This displays the pages with aniframe-based thumbnail, similar to CodePen and one of our old bespoke pattern libraries.The biggest change from our previous implementations of this pattern are that the thumbnail itself is flexible, there's still plenty of room available for text-based descriptions, and loading of actual
iframeelements is deferred till the rest of the page has loaded.Screenshots
Narrow
Wide
@mrgerardorodriguez @erikjung @saralohr @nicolemors @aileenjeffries
Closes #8, See #19