Add source maps to module server #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebeby
changed the title
Comment on lines
+34
to
+35
| // Create a new console instance instead of using the global one | ||
| // Because the global one is overridden by Jest, and it adds a misleading second stack trace and code frame below it |
There was a problem hiding this comment.
I appreciate these types of comments, thank you! 🎉
gerardo-rodriguez
approved these changes
Jun 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if code in
runJSorloadJS, or imported by either of those, triggers an error, the error stack is source-mapped back to correct locations. Here's the original PR that implemented this for the vite-based server. That PR has screenshots showing the feature.The tests pretty well cover the feature so I don't think manual testing is needed.