Improve error message when Promise is passed into jest-dom matcher #139

calebeby · 2021-07-07T15:23:38Z

If you do this:

await expect(screen.getByText(/asdf/))

That code is wrong because the getByText query is not awaited.

Previously, the error message in that case was along the lines of elementHandle.asElement is not a function. Now the error message is:

Paul-Hebert

Code and tests look good! Left one non-blocking nit inline.

This is a great DX improvement! I've been bitten by forgetting await in Stencil E2E tests and the error there is much less helpful 😅

src/extend-expect.ts

tests/extend-expect.test.ts

calebeby added 3 commits July 7, 2021 08:07

Improve error message when Promise is passed into jest-dom matcher

df1cc13

Commit missing changes

fbf1f22

Add tests

b23c582

calebeby requested review from spaceninja, gerardo-rodriguez and Paul-Hebert July 7, 2021 15:23

Paul-Hebert approved these changes Jul 7, 2021

View reviewed changes

src/extend-expect.ts Outdated Show resolved Hide resolved

tests/extend-expect.test.ts Show resolved Hide resolved

Refactor based on feedback

912e3f9

calebeby merged commit 1d5f16c into main Jul 7, 2021

calebeby deleted the improve-jest-dom-promise-error branch July 7, 2021 22:38

github-actions bot mentioned this pull request Jul 7, 2021

Publish Next Version #144

Merged

Provide feedback