Refactor and improve browser stack trace printing #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three changes to the way from-browser stack traces are printed now:
http://localhost:2345/@npm/react
would be printed as-is (since we don't generate source maps for node_modules). But when that happened, Jest would not be able to parse the stack trace (because it doesn't understand URL's, only file paths), and that would prevent it from displaying a code frame for any line in the error. Now the@npm
URL's get rewritten to absolute node_modules paths.at FuncName (filePath:0:0)
) were one of the things that Jest's error stack parser was not able to recognize. It turns out that it is able to recognize those, so now the code for conditionally displaying the function names depending on code frames has been removed.