Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore HTML comments in getAccessibilityTree output #412

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Ignore HTML comments in getAccessibilityTree output #412

merged 1 commit into from
Feb 18, 2022

Conversation

calebeby
Copy link
Member

Closes #411

spaceninja
spaceninja approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@spaceninja spaceninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick fix!

@calebeby calebeby merged commit 33ddf04 into main Feb 18, 2022
@calebeby calebeby deleted the getAccessibilityTree-ignore-comments branch February 18, 2022 01:20
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceninja spaceninja spaceninja approved these changes

@gerardo-rodriguez gerardo-rodriguez Awaiting requested review from gerardo-rodriguez

@Paul-Hebert Paul-Hebert Awaiting requested review from Paul-Hebert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should HTML comments be included in accessibility tree?
2 participants
@calebeby @spaceninja