Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement user.selectOptions() #60

Merged
merged 4 commits into from
May 13, 2021
Merged

Implement user.selectOptions() #60

merged 4 commits into from
May 13, 2021

Conversation

calebeby
Copy link
Member

@calebeby calebeby commented May 13, 2021 •
edited
Loading

Reimplements https://github.com/testing-library/user-event#selectoptionselement-values using Puppeteer methods, and adds it to the user object

@calebeby calebeby changed the title Implement user.selectOptions() Implement user.selectOptions() May 13, 2021
spaceninja
spaceninja approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@spaceninja spaceninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with this code to be 100% confident in approving it, but the changes look reasonable.

gerardo-rodriguez
gerardo-rodriguez approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @calebeby! 🎉

@calebeby calebeby merged commit f5c2fab into main May 13, 2021
@github-actions github-actions bot mentioned this pull request May 13, 2021
Merged
@calebeby calebeby deleted the select-options branch May 13, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardo-rodriguez gerardo-rodriguez gerardo-rodriguez approved these changes

@spaceninja spaceninja spaceninja approved these changes

@Paul-Hebert Paul-Hebert Awaiting requested review from Paul-Hebert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebeby @spaceninja @gerardo-rodriguez