Fix race condition in test_threaded
#22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `test_threaded()` started a thread that made two writes to each pipe. This had the potential for a race condition since the read might occur between the two writes. This changes it to make only one write for each pipe. This maintains the two byte buffer despite reading only one byte just to confirm that it never somehow reads too much. An alternate solution would be to fill buffers for each of the pipes and wait until they closed to check what was read. I thought that would be significantly more complicated. I observed the race condition under Linux on Rust 1.71.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
test_threaded()started a thread that made two writes to each pipe. This had the potential for a race condition since the read might occur between the two writes. This changes it to make only one write for each pipe.This maintains the two byte buffer despite reading only one byte just to confirm that it never somehow reads too much.
An alternate solution would be to fill buffers for each of the pipes and wait until they closed to check what was read. I thought that would be significantly more complicated.
I observed the race condition under Linux on Rust 1.71.0.