Angular5 #115
Angular5 #115
Conversation
tsconfig.json
Outdated
| @@ -21,6 +22,7 @@ | |||
| "compiled" | |||
| ], | |||
| "angularCompilerOptions": { | |||
| "strictMetadataEmit": true, | |||
| "genDir": "compiled" | |||
There was a problem hiding this comment.
Shouldn't we change this to "skipTemplateCodeGen": true ?
There was a problem hiding this comment.
strictMetadataEmit Produces an error if the metadata written for a class would produce an error if used, so I vote to keep it.
I will add "skipTemplateCodeGen": true
| @@ -3,7 +3,7 @@ import {Http, Response} from '@angular/http'; | |||
| import {Observable} from 'rxjs/Observable'; | |||
| import 'rxjs/add/operator/map'; | |||
There was a problem hiding this comment.
Change to rxjs/operators and use pipe (Applies to all rxjs...)
samples/photo_album/package.json
Outdated
| "@angular/platform-browser-dynamic": "^5.0.1", | ||
| "@angular/platform-server": "^5.0.1", | ||
| "@angular/router": "^5.0.1", | ||
| "@cloudinary/angular-5.x": "file:../../cloudinary-angular-5.x-v1.0.0.tgz", |
There was a problem hiding this comment.
Also not sure why it is
v1.0.0
instead of
1.0.0 ...
There was a problem hiding this comment.
It's temporary, since SDK version 5 is not in NPM yet.
Referencing a non-existing file won't build (and I know that the build is borken while referencing a local file), but a missing NPM file will also corrupt package-lock.json.
Once the v5 of SDK is published I will update all samples to point to NPM.
| @@ -4,7 +4,7 @@ import {NgModule} from '@angular/core'; | |||
| import {BrowserModule} from '@angular/platform-browser'; | |||
| import {HttpModule} from '@angular/http'; | |||
There was a problem hiding this comment.
Replace HttpModule with HttpClientModule
import {HttpClientModule} from '@angular/common/http';
Replace SDK links from 4.x to 5.x
|
I'm not positive but I think this commit might have broken the bower install for My build stopped working and the last time I was able to successfully build was on 11/21. |
Upgrade SDK + samples to Angular5
Fixes #114