Skip to content

Conversation

leonardehrenfried
Copy link

Many of the dependencies were very old and had to be upgraded too.

@leonardehrenfried
Copy link
Author

Seems that test fail because CLOUDINARY_URL is not set. I guess that is set in the encrypted Travis value.

@tocker
Copy link
Contributor

tocker commented Dec 21, 2017

That's normal. Travis doesn't pass encrypted variables to external PRs.
I'm assuming you ran the tests locally with your own CLOUDINARY_URL.
We'll run the tests internally before merging.

@jgrape
Copy link
Contributor

jgrape commented Feb 27, 2018

Any chance of getting this fixed and merged? My project has moved to Scala 2.12 and Play 2.6. What can I do to help?

@yakirp
Copy link

yakirp commented Feb 28, 2018

Hi @jgrape,

let's merge this issue with #23

Thanks,
Yakir

@balagez
Copy link

balagez commented Jun 23, 2018

Any chance for this or #27 getting merged any time soon? Cloudinary is the last thing that prevents my org from switching to 2.12.

Thanks so much!

@roeeba roeeba assigned asisayag2 and unassigned tocker Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants