remove the cld video player if its not included #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuval-cloudinary
requested changes
Dec 12, 2024
| @@ -73,6 +73,18 @@ window.renderCloudinaryVideoPlayer = function () { | |||
| } | |||
| } | |||
| }); | |||
| const targetNode = document.querySelector('#cld-video-player'); | |||
There was a problem hiding this comment.
Why aren't we preventing the node from getting created at the first place?
Wouldn't we have the browser loading the VP widget and then discarding it?
There was a problem hiding this comment.
It only happening in the case of custom mapping, in that scenario cartridge is creating URLs based on the configurations in custom mapping and it's not sure if the video is available in DOM before creating the URL, and I don't find any way to check if the video is available in DOM before rendering the video player
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.