Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced util.puts with console.log #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replaced util.puts with console.log #66

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2014

Using util.puts now prints a message to console about using console.log instead which clutters up test suites. This PR replaces util.puts with console.log.

@Kami
Copy link
Member

Kami commented Jan 7, 2014

@isaacbw The change looks good, but I've noticed you pinned node-terminal to your fork.

I know that node-terminal needs to be updated as well, because Whiskey uses it inside the reporters, but this change should be submitted and done upstream.

If you open a pull request on node-terminal repository and it looks good, I'm happy to merge it.

Edit: Sorry! I totally missed that you also submitted a pull request to node-terminal repository. For some reason I didn't receive a notification.

@ghost
Copy link
Author

ghost commented Jan 7, 2014

Ah, I meant for the github dependency to be in advance of the PR. I assumed a PR would be attached to the commit at the time of the request.

@Kami
Copy link
Member

Kami commented Jan 7, 2014

@isaacbw No problem.

I will publish a new version of node-terminal mode to npm once your pull request is merged and let you know so you can update this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant