Branch v1.14.0 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
FishermanZzhang
commented
Jun 15, 2021
FishermanZzhang
commented
- Get cluster from ckman by url
- Get user from ranger by url
- add monitor(ck user) to heartbeart and kill/cancel query
- add default quota if range not set
- support basic and params to auth
godliness
reviewed
Jun 16, 2021
| if err := unmarshal((*plain)(m)); err != nil { | ||
| return err | ||
| } | ||
| if m.MaxConcurrentQueries == 0 { |
|
|
|
你自己创建自己的分支（简要命名分支，例如add-chproxy-sync-ranger 之类的）往 branch-v1.14.0 合入， 而不是master |
|
描述要体现出 what why how, 就是你干了什么， 为什么这个干， 怎么干的， 简要描述 |
|
由于提交PR所merge的目标分支不对，暂不进行code review. |
|
另外，目前项目不是private的？ |
Collaborator
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.