Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/golang/protobuf from 1.4.3 to 1.5.2 #1101

Merged
merged 3 commits into from
Dec 2, 2021
Merged

build(deps): bump github.com/golang/protobuf from 1.4.3 to 1.5.2 #1101

merged 3 commits into from
Dec 2, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 7, 2021 •
edited
Loading

Bumps github.com/golang/protobuf from 1.4.3 to 1.5.2.

Release notes

Sourced from github.com/golang/protobuf's releases.

v1.5.2

Notable changes:

  • (#1306) all: deprecate the module
  • (#1300) jsonpb: restore previous behavior for handling nulls and JSONPBUnmarshaler

v1.5.1

Notable changes:

v1.5.0

Overview

This marks the ptypes package as deprecated and upgrades the dependency on google.golang.org/protobuf to a pre-release version of v1.26.0. A subsequent patch release will update the dependency to v1.26.0 proper.

Notable changes

  • (#1217) ptypes: deprecate the package
  • (#1214) rely on protodesc.ToFileDescriptorProto
Commits
  • ae97035 all: deprecate the module (#1306)
  • af94003 jsonpb: restore previous behavior for handling nulls and JSONPBUnmarshaler (#...
  • a36a1a1 all: depend on google.golang.org/protobuf@v1.26.0 (#1293)
  • f746d3b all: depend on google.golang.org/protobuf@v1.26.0-rc.1 (#1292)
  • 78b1f09 Switch from Travis-CI to GitHub actions (#1286)
  • acacf81 all: rely on protodesc.ToFileDescriptorProto (#1214)
  • eccd77d ptypes: deprecate the package (#1217)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 7, 2021
@dependabot dependabot bot force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch from f6e3837 to e02d16a Compare June 7, 2021 11:24
@mrueg
Copy link
Collaborator

mrueg commented Jun 8, 2021

This probably needs some rework as staticcheck is failing:

pkg/controllers/routing/network_routes_controller_test.go:19:2    staticcheck  SA1019: package github.com/golang/protobuf/ptypes is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.

@dependabot dependabot bot force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch 3 times, most recently from c86e72c to 886c527 Compare July 5, 2021 21:20
@mrueg
Copy link
Collaborator

mrueg commented Jul 5, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch from 886c527 to 709fbf2 Compare July 5, 2021 22:48
@dependabot dependabot bot force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch from 709fbf2 to acf5839 Compare August 2, 2021 23:33
@dependabot dependabot bot force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch from acf5839 to f30ad15 Compare August 10, 2021 12:32
@dependabot dependabot bot force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch from f30ad15 to f9d93e9 Compare September 2, 2021 12:27
@dependabot dependabot bot force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch from f9d93e9 to 80b70b4 Compare October 31, 2021 18:14
dependabot bot and others added 3 commits December 1, 2021 09:28
@dependabot @aauren
build(deps): bump github.com/golang/protobuf from 1.4.3 to 1.5.2
84052e6 
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.4.3 to 1.5.2.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.4.3...v1.5.2)

---
updated-dependencies:
- dependency-name: github.com/golang/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@aauren
fix(go.mod): add google.golang.org/protobuf v1.26.0
959d57d 
Add an older version of Protobuf from the v2 API so that we can still
use the deprecated ptypes structures from Protobuf v1 which GoBGP still
relies on.
@aauren
fix(lint): don't error on deprecated protobuf funcs
26805fe
@aauren aauren force-pushed the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch from 80b70b4 to 26805fe Compare December 1, 2021 21:30
@aauren
Copy link
Collaborator

aauren commented Dec 1, 2021

@mrueg - It seems like adding an older version of Protobuf from the Protobuf v2 import path has resolved this for now and allows us to use the deprecated functions from Protobuf v1 until GoBGP updates their version of Protobuf (osrg/gobgp#2485)

More information about the breaking Protobuf API changes that we're running into can be found here: https://go.dev/blog/protobuf-apiv2

I don't claim to be an expert on Protobuf or the implications of including two versions of the Protobuf library from different import paths in Go. But this change allows the tests to pass on my system, and putting it on a host to test, I'm still able to communicate with GoBGP (proving that the protobufs still work) and kube-router seems to operate normally.

@mrueg / @murali-reddy - I'd appreciate a second set of eyes on this to see if you see anything wrong with this approach.

@aauren aauren mentioned this pull request Dec 1, 2021
Merged
@mrueg
Copy link
Collaborator

mrueg commented Dec 1, 2021

Seems reasonable to me :) thanks for doing the work

@mrueg mrueg merged commit b9a9246 into master Dec 2, 2021
@dependabot dependabot bot deleted the 47f3dependabot/go_modules/github.com/golang/protobuf-1.5.2 branch December 2, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrueg @aauren