Fix Ddd hostPID to Daemonsets #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because cloudnativelabs#1582 which was recently merged relies upon finding the correct veth interface via /proc/<pid> which isn't available unless kube-router is in the same process namespace. hostPID and hostIPC was always required for DSR functionality, but now hostPID is needed for hairpin to be available.
Direct people to a potentially missing hostPID attribute in their kube-router deployment if they are getting a no such file or directory message.
|
Progress towards: #1596 |
aauren
added a commit
to aauren/kops
that referenced
this pull request
Mar 31, 2024
* Update version v1.6.0 -> v2.1.0
* expose container runtime socket to kube-router
* kube-router loadbalancer controller
* Add access / information that is needed by the load balancer
controller in kube-router.
* add access to endpoint slices for services controller
* enable hairpin mode on kube-router
* There are integration tests in kops that expect that hairpin
functionality is always enabled, as such we now enable hairpin-mode
in kube-router by default.
* enable hostPID access
* kube-router now requires access to the host's process namespace. See
cloudnativelabs/kube-router#1584 for more
information.
hakman
pushed a commit
to hakman/kops
that referenced
this pull request
Apr 1, 2024
* Update version v1.6.0 -> v2.1.0
* expose container runtime socket to kube-router
* kube-router loadbalancer controller
* Add access / information that is needed by the load balancer
controller in kube-router.
* add access to endpoint slices for services controller
* enable hairpin mode on kube-router
* There are integration tests in kops that expect that hairpin
functionality is always enabled, as such we now enable hairpin-mode
in kube-router by default.
* enable hostPID access
* kube-router now requires access to the host's process namespace. See
cloudnativelabs/kube-router#1584 for more
information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1582 was merged, we now rely upon having access to the host's PID namespace in order to detect which veth device a given container doing hairpinning is using. As such, we now add it to the daemonsets in the example and attempt to direct users upon certain errors.