Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodash-es issue #278

Closed
LoanCaecke opened this issue Oct 26, 2022 · 4 comments · Fixed by #293
Closed

lodash-es issue #278

LoanCaecke opened this issue Oct 26, 2022 · 4 comments · Fixed by #293
Labels

Comments

@LoanCaecke
Copy link

Hello,

In order to make my ng serve compiling I had to install the lib with npm install lodash-es npx-sub-form

It seems like issue #55 is back again

Have a good day,

@it11ah1
Copy link

it11ah1 commented Jan 11, 2023

It could come from v6.0.3 which added lodash's cloneDeep but didn't handle the dependency properly.

@acadianaapps
Copy link
Contributor

Experiencing this in the 7.0.0

config:

"dependencies": {
"@angular/animations": "^14.1.0",
"@angular/cdk": "^14.1.2",
"@angular/common": "^14.1.0",
"@angular/compiler": "^14.1.0",
"@angular/core": "^14.1.0",
"@angular/fire": "^7.4.1",
"@angular/flex-layout": "^14.0.0-beta.40",
"@angular/forms": "^14.1.0",
"@angular/material": "^14.1.2",
"@angular/platform-browser": "^14.1.0",
"@angular/platform-browser-dynamic": "^14.1.0",
"@angular/router": "^14.1.0",
"@angular/service-worker": "^14.1.0",
"@ngxs/form-plugin": "^3.7.5",
"@ngxs/router-plugin": "^3.7.5",
"@ngxs/storage-plugin": "^3.7.5",
"@ngxs/store": "^3.7.5",
"@sentry/angular": "^7.11.1",
"@sentry/browser": "^7.11.1",
"firebaseui": "^6.0.1",
"firebaseui-angular": "^6.1.2",
"lodash-es": "^4.17.21",
"ngx-sub-form": "^7.0.0",
"rxjs": "~7.5.6",
"tslib": "^2.3.0",
"zone.js": "~0.11.4"
},
"devDependencies": {
"@angular-devkit/build-angular": "^14.1.2",
"@angular/cli": "~14.1.2",
"@angular/compiler-cli": "^14.1.0",
"@ngxs/devtools-plugin": "^3.7.5",
"@types/jasmine": "~4.0.0",
"jasmine-core": "~4.2.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.0.0",
"typescript": "~4.7.2"
}

@maxime1992
Copy link
Contributor

I believe we're just missing lodash-es here if someone can raise a PR :)

https://github.com/cloudnc/ngx-sub-form/blob/master/projects/ngx-sub-form/package.json#L8

acadianaapps added a commit to acadianaapps/ngx-sub-form that referenced this issue Feb 9, 2023
added lodash-es to peer dependencies

Closes cloudnc#278
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

🎉 This issue has been resolved in version 8.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants