Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Angular 16 #298

Closed
erikmom opened this issue Jul 3, 2023 · 1 comment · Fixed by #301
Closed

Upgrade to Angular 16 #298

erikmom opened this issue Jul 3, 2023 · 1 comment · Fixed by #301
Assignees
@erikmom
Labels
effort-1: minutes Will only take a few minutes to fix/create flag: breaking change This feature or fix will require a breaking change flag: good for first contribution Good for a first PR on the repo PR-state: WIP This PR is a work in progress released state: community Someone from the community is working on this issue or submitted that PR state: has PR A PR is available for that issue

Comments

@erikmom
Copy link
Contributor

erikmom commented Jul 3, 2023

The current peerDependencies of ngx-subform are configured as ^15.0.0. When upgrading Angular to version 16, during npm install, the user will be notified that peerDependencies are incompatible.
erikmom added a commit to erikmom/ngx-sub-form that referenced this issue Jul 3, 2023
@erikmom
Updated Readme
244c55e 
This closes cloudnc#298
@maxime1992 maxime1992 added effort-1: minutes Will only take a few minutes to fix/create flag: breaking change This feature or fix will require a breaking change PR-state: WIP This PR is a work in progress state: community Someone from the community is working on this issue or submitted that PR state: has PR A PR is available for that issue flag: good for first contribution Good for a first PR on the repo labels Jul 3, 2023
erikmom added a commit to erikmom/ngx-sub-form that referenced this issue Jul 5, 2023
@erikmom
feat: Upgrades to Angular 16
2a20e1b 
BREAKING CHANGE: Angular 16 required

This closes cloudnc#298

Also wanted to to upgrade typescript to a 5.x.x version, but the Cypress typescript compilation failed, because of cypress-io/cypress#26203
erikmom added a commit to erikmom/ngx-sub-form that referenced this issue Jul 5, 2023
@erikmom
feat: Upgrades to Angular 16
d244864 
BREAKING CHANGE: Angular 16 required

This closes cloudnc#298

Also wanted to to upgrade typescript to a 5.x.x version, but the Cypress typescript compilation failed, because of cypress-io/cypress#26203
@erikmom erikmom mentioned this issue Jul 5, 2023
Merged
erikmom added a commit to erikmom/ngx-sub-form that referenced this issue Jul 5, 2023
@erikmom
feat: Upgrades to Angular 16
dd86371 
BREAKING CHANGE: Angular 16 required

This closes cloudnc#298

Also wanted to to upgrade typescript to a 5.x.x version, but the Cypress typescript compilation failed, because of cypress-io/cypress#26203
erikmom added a commit to erikmom/ngx-sub-form that referenced this issue Jul 5, 2023
@erikmom
feat: Upgrades to Angular 16
9ddae0d 
BREAKING CHANGE: Angular 16 required

This closes cloudnc#298

Also wanted to to upgrade typescript to a 5.x.x version, but the Cypress typescript compilation failed, because of cypress-io/cypress#26203
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikmom erikmom

Labels
effort-1: minutes Will only take a few minutes to fix/create flag: breaking change This feature or fix will require a breaking change flag: good for first contribution Good for a first PR on the repo PR-state: WIP This PR is a work in progress released state: community Someone from the community is working on this issue or submitted that PR state: has PR A PR is available for that issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Upgrades to Angular 16 erikmom/ngx-sub-form
2 participants
@erikmom @maxime1992