Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formControlNames returns array when control is array type #73

Closed
zakhenry opened this issue Jul 15, 2019 · 1 comment · Fixed by #78
Closed

formControlNames returns array when control is array type #73

zakhenry opened this issue Jul 15, 2019 · 1 comment · Fixed by #78
Assignees
@maxime1992
Labels
effort-1: minutes Will only take a few minutes to fix/create released scope: demo Anything related only to the demo scope: doc If anything is missing or should be clarified on the documentation scope: lib Anything related to the library itself state: has PR A PR is available for that issue type: bug/fix This is a bug or at least needs a fix workaround-1: obvious Obvious workaround

Comments

@zakhenry
Copy link
Contributor

In the readme, if you change

  <div
    class="crew-member"
    formArrayName="crewMembers"
    *ngFor="let crewMember of formGroupControls.crewMembers.controls; let i = index"
  >

to

  <div
    class="crew-member"
    [formArrayName]="formControlNames.crewMembers" 
    *ngFor="let crewMember of formGroupControls.crewMembers.controls; let i = index"
  >

An error is thrown
@zakhenry zakhenry added effort-1: minutes Will only take a few minutes to fix/create scope: demo Anything related only to the demo scope: doc If anything is missing or should be clarified on the documentation scope: lib Anything related to the library itself type: bug/fix This is a bug or at least needs a fix workaround-1: obvious Obvious workaround labels Jul 15, 2019
@maxime1992 maxime1992 added effort-2: hours Will only take a few hours to fix/create and removed effort-1: minutes Will only take a few minutes to fix/create labels Jul 18, 2019
@maxime1992 maxime1992 self-assigned this Jul 18, 2019
maxime1992 added a commit that referenced this issue Jul 18, 2019
@maxime1992
fix(lib): formControlNames returns array when control is array type
c54e882 
This closes #73
@maxime1992 maxime1992 mentioned this issue Jul 18, 2019
Merged
@maxime1992 maxime1992 added state: has PR A PR is available for that issue effort-1: minutes Will only take a few minutes to fix/create and removed effort-2: hours Will only take a few hours to fix/create labels Jul 18, 2019
maxime1992 added a commit that referenced this issue Jul 20, 2019
@maxime1992
fix(lib): formControlNames returns array when control is array type
9ce113d 
This closes #73
maxime1992 added a commit that referenced this issue Jul 20, 2019
@maxime1992
fix(lib): formControlNames returns array when control is array type
8bdf874 
This closes #73
@maxime1992
Copy link
Contributor

🎉 This issue has been resolved in version 2.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maxime1992 maxime1992 mentioned this issue Aug 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxime1992 maxime1992

Labels
effort-1: minutes Will only take a few minutes to fix/create released scope: demo Anything related only to the demo scope: doc If anything is missing or should be clarified on the documentation scope: lib Anything related to the library itself state: has PR A PR is available for that issue type: bug/fix This is a bug or at least needs a fix workaround-1: obvious Obvious workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lib): formControlNames returns array when control is array type cloudnc/ngx-sub-form
2 participants
@zakhenry @maxime1992