Merge pull request #40 from cloudogu/bugfix/39_sharp_dev_dependency

Bugfix/39 sharp dev dependency

.gitignore

@@ -47,3 +47,4 @@ jspm_packages
 # Intellij
 .idea/*
 *.iml
+tmp

CHANGELOG.md

@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+- Move `sharp` to dev dependencies (#39)
+- Pin `bootstrap-sass` to `3.4.1` because of build issues
+  - https://github.com/twbs/bootstrap-sass/issues/1228#issuecomment-1069310370
 
 ## [v0.7.1] - 2022-09-19
 ### Fixed

Makefile

@@ -0,0 +1,41 @@
+.DEFAULT_GOAL:=build
+
+.PHONY: gen-audit
+gen-audit: gen-audit-severity gen-audit-prod
+
+.PHONY: result-dir
+result-dir:
+	@mkdir -p tmp
+
+.PHONY: gen-audit-prod
+gen-audit-prod: result-dir
+	@mkdir -p target
+	@-npm audit --json --prod 1> target/audit_prod.json
+
+.PHONY: gen-audit-dev
+gen-audit-dev: result-dir
+	@mkdir -p target
+	@-npm audit --json --dev 1> target/audit_dev.json
+
+.PHONY: gen-audit-severity-all
+gen-audit-severity-all: gen-audit-dev
+	@cat target/audit_dev.json | jq '.advisories | with_entries(select(.value.severity == "low"))' 1> target/audit_dev_low.json
+	@cat target/audit_dev.json | jq '.advisories | with_entries(select(.value.severity == "moderate"))' 1> target/audit_dev_moderate.json
+	@cat target/audit_dev.json | jq '.advisories | with_entries(select(.value.severity == "high"))' 1> target/audit_dev_high.json
+	@cat target/audit_dev.json | jq '.advisories | with_entries(select(.value.severity == "critical"))' 1> target/audit_dev_critical.json
+
+.PHONY: build
+build: install
+	gulp
+
+.PHONY: serve
+serve: install
+	gulp serve
+
+.PHONY: install
+install:
+	npm install -g gulp bower
+	npm install
+	bower install
+	npm rebuild node-sass
+	npm rebuild sharp

README.md

@@ -10,24 +10,24 @@ Theme for CES WebApplications, based on Twitter Bootstrap.
 * Install the following:
   - Install [git](https://git-scm.com)
   - Install [Node Version Manager](https://github.com/nvm-sh/nvm)
-* You need to use Node 8
-  * `nvm install 8 && nvm use 8`
+* You need to use Node 10
+  * `nvm install 10 && nvm use 10`
 * Then install gulp and bower globally with `npm install -g gulp bower`
 * Clone the repository
 * Install local dependencies inside the repository, if necessary:
   - On Windows install the following: [Windows-Build-Tools](https://github.com/felixrieseberg/windows-build-tools)
 * Build
 ```
-npm install
-bower install
+make
 ```
-* Start development server with `gulp serve` 
-* Build with `gulp`
+* Start development server with `make serve` 
+* Build with `make`
 
 ### Troubleshooting
 > * If `gulp` exits with a file not found error try deleting the `node_modules` directory and reinstall the dependencies with `npm install`.
 > * If `gulp serve` does not run correctly, and the error is in one of the included node-modules, then a rebuild of the package in question may help
     (`npm rebuild <node-module>`).
+>   * possible candidates are node-sass and sharp
 > 
 ## Usage
 * npm or bower

bower.json

@@ -23,6 +23,6 @@
     "tests"
   ],
   "devDependencies": {
-    "bootstrap-sass": "^3.3.6"
+    "bootstrap-sass": "3.4.1"
   }
 }