Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugins): set timeout for helm upgrade / install #884

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Feb 5, 2025

Description

  • Sets timeout for helm install and upgrade actions in-order to not have a blocking reconciliation
  • Increases plugin controller MaxConcurrent reconciles to 3

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan self-assigned this Feb 5, 2025
@abhijith-darshan abhijith-darshan marked this pull request as ready for review February 5, 2025 15:10
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner February 5, 2025 15:10
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also for bringing the unused parameters to attention.

pkg/helm/helm.go Outdated Show resolved Hide resolved
pkg/helm/helm.go Outdated Show resolved Hide resolved
pkg/helm/helm.go Outdated Show resolved Hide resolved
pkg/helm/helm.go Outdated Show resolved Hide resolved
@abhijith-darshan abhijith-darshan merged commit 6564bc5 into main Feb 7, 2025
21 checks passed
@abhijith-darshan abhijith-darshan deleted the plugin/helm_timeout branch February 7, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - HelmController stalls on HelmUpgrade
2 participants