Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): remove legacy e2e setup #886

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Conversation

abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Feb 6, 2025

Description

As part of the clean up task, this PR removes the legacy e2e setup

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • πŸ“œ README.md
  • 🀝 Documentation pages updated
  • πŸ™… no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan self-assigned this Feb 6, 2025
@abhijith-darshan abhijith-darshan marked this pull request as ready for review February 6, 2025 09:40
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner February 6, 2025 09:40
kengou
kengou previously approved these changes Feb 6, 2025
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhijith-darshan
Copy link
Contributor Author

Please make sure to update the mentions in the documentation as well. https://github.com/search?q=repo%3Acloudoperators%2Fgreenhouse+e2e+language%3AMarkdown&type=code&l=Markdown

Hey @IvoGoman , working on removing dev-env, it has bit of a larger change as it has deployed documenation. So when I cover that I will tackle it as it has to be completely re-written.

@abhijith-darshan abhijith-darshan merged commit 2f9bd0f into main Feb 7, 2025
21 checks passed
@abhijith-darshan abhijith-darshan deleted the chore/legacy_e2e_clean branch February 7, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants