-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): migrate Panel, PanelBody and PanelFooter components to Typescript #606
Conversation
🦋 Changeset detectedLatest commit: 6af2b12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job and few breaking changes :)
Hey, @barsukov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewing :)
packages/ui-components/src/components/Panel/Panel.component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Panel
,PanelBody
andPanelFooter
components toTypeScript
, enhancing code quality, maintainability, and scalability.Portal
is used (which is in progress).ContentArea
andContentAreaWrapper
from Stories already as they're deprecated.Changes Made
TypeScript Migration:
Panel
,PanelBody
andPanelFooter
components files toTypeScript
..js
components to thedeprecated_js
folder.Portal
is used (which is in progress).Refactoring:
Testing:
Panel
PanelBody
PanelFooter
Storybook
.vitest
.Documentation:
Storybook
documentation types and comments.Release:
changeset
file.Related Issues
Testing Instructions
Storybook
Checklist