Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): update renovate config #643

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

taymoor89
Copy link
Contributor

Summary

Renovate was still scanning dependencies of all packages and apps. This PRs limits managers to just npm and github-actions as well as only scans dependencies for ui-components using includePaths.

Changes Made

  • Limited managers to npm and github-actions
  • Changed scan schedule
  • Extended recommended config config:best-practices
  • Removed customManager as it was just copied over from greenhouse project and not needed at the moment

Related Issues

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@taymoor89 taymoor89 requested a review from a team as a code owner November 28, 2024 12:12
Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 6338337

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@taymoor89 taymoor89 self-assigned this Nov 28, 2024
@taymoor89 taymoor89 added the ui-components All tasks related to juno-ui-components library label Nov 28, 2024
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taymoor89 taymoor89 merged commit 2ac6029 into main Nov 29, 2024
13 checks passed
@taymoor89 taymoor89 deleted the taimoor-limit-renovate-managers branch November 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants