fix security group ids

Signed-off-by: Vacant2333 <vacant2333@gmail.com>
cloudpilot-ai · Dec 2, 2024 · 159d93d · 159d93d
1 parent 9a44e87
commit 159d93d
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/pkg/providers/instance/instance.go b/pkg/providers/instance/instance.go
@@ -533,14 +533,10 @@ func (p *DefaultProvider) getProvisioningGroup(ctx context.Context, nodeClass *v
 		AutoProvisioningGroupType:       tea.String("instant"),
 		LaunchConfiguration: &ecsclient.CreateAutoProvisioningGroupRequestLaunchConfiguration{
 			// TODO: we should set image id for each instance types after alibabacloud supports
-			ImageId:          tea.String(imageID),
-			SecurityGroupIds: securityGroupIDs,
-			UserData:         tea.String(userData),
-
-			// TODO: AutoProvisioningGroup is not compatible with SecurityGroupIds, waiting for Aliyun developers to fix it,
-			// so here we only take the first one.
+			ImageId:                    tea.String(imageID),
+			UserData:                   tea.String(userData),
 			ResourceGroupId:            tea.String(nodeClass.Spec.ResourceGroupID),
-			SecurityGroupId:            securityGroupIDs[0],
+			SecurityGroupIds:           securityGroupIDs,
 			SystemDiskSize:             systemDisk.Size,
 			SystemDiskPerformanceLevel: systemDisk.PerformanceLevel,
 			Tag:                        reqTags,