Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate the overhead correctly #158

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

jwcesign
Copy link
Contributor

@jwcesign jwcesign commented Dec 2, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

referring to https://help.aliyun.com/zh/ack/ack-managed-and-ack-dedicated/user-guide/resource-reservation-policy#0f5ffe176df7q

Caculate the overhead correctly

Which issue(s) this PR fixes:

Fixes #none

Special notes for your reviewer:

none

Does this PR introduce a user-facing change?


Copy link

gitautomator bot commented Dec 2, 2024

Thanks to your contribution, the maintainers will review it as soon as they can!

@jwcesign
Copy link
Contributor Author

jwcesign commented Dec 2, 2024

Copy link
Contributor

@helen-frank helen-frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other /lgtm

pkg/providers/instancetype/types.go Show resolved Hide resolved
Signed-off-by: jwcesign <jwcesign@cloudpilot.ai>
Copy link
Contributor

@helen-frank helen-frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jwcesign jwcesign merged commit c5ad91c into cloudpilot-ai:main Dec 3, 2024
1 check passed
@jwcesign
Copy link
Contributor Author

/cherry-pick release-0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants