feat: implement cloudprovider Get and List #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to your contribution, the maintainers will review it as soon as they can! |
helen-frank
force-pushed
the
cloudeproider
branch
2 times, most recently
from
7fb0f57 to
64f2dc0
Compare
helen-frank
changed the title
helen-frank
force-pushed
the
cloudeproider
branch
from
64f2dc0 to
368bd7d
Compare
helen-frank
changed the title
helen-frank
force-pushed
the
cloudeproider
branch
from
368bd7d to
532d1dc
Compare
|
/cc @jwcesign @daimaxiaxie @IrisIris Please take a look |
daimaxiaxie
reviewed
Oct 9, 2024
jwcesign
reviewed
Oct 9, 2024
helen-frank
force-pushed
the
cloudeproider
branch
from
532d1dc to
7f48e7b
Compare
helen-frank
force-pushed
the
cloudeproider
branch
3 times, most recently
from
3ccc658 to
f9600c8
Compare
|
/cc @jwcesign @daimaxiaxie Please review the code again |
helen-frank
force-pushed
the
cloudeproider
branch
from
f9600c8 to
9746202
Compare
jwcesign
reviewed
Oct 10, 2024
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
implement cloudprovider Get and List
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?