chore: use ack provider to resolve the cluster cni #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to your contribution, the maintainers will review it as soon as they can! |
|
cc @helen-frank for checking |
helen-frank
approved these changes
Nov 7, 2024
jxs1211
reviewed
Nov 7, 2024
pkg/providers/ack/ack.go
Outdated
| ackClient: ackClient, | ||
| clusterID: clusterID, | ||
| ackClient: ackClient, | ||
| clusterCNI: "", |
There was a problem hiding this comment.
Is an empty string necessary here?
There was a problem hiding this comment.
Not necessary, thanks for suggestion
jxs1211
reviewed
Nov 7, 2024
| func (p *DefaultProvider) LivenessProbe(_ *http.Request) error { | ||
| p.muClusterCNI.Lock() | ||
| //nolint: staticcheck | ||
| p.muClusterCNI.Unlock() |
There was a problem hiding this comment.
Is there any write operation here? Maybe it doesn't need the lock and unlock operation if just a read operation.
There was a problem hiding this comment.
It's used to check whether it is in dead-lock state. aws provider does this.
Signed-off-by: jwcesign <jwcesign@cloudpilot.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
chore: use ack provider to resolve the cluster cni
Which issue(s) this PR fixes:
Fixes #91
Special notes for your reviewer:
Does this PR introduce a user-facing change?