chore: initialization project #6
Open
+1,565
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to your contribution, the maintainers will review it as soon as they can! |
jwcesign
reviewed
Dec 16, 2024
helen-frank
force-pushed
the
feat/init
branch
2 times, most recently
from
ae35ee3 to
f08e9a0
Compare
jwcesign
approved these changes
Dec 18, 2024
…acloud Signed-off-by: helen frank <helenfrank@protonmail.com>
helen-frank
force-pushed
the
feat/init
branch
from
f08e9a0 to
ff82d93
Compare
jwcesign
reviewed
Dec 18, 2024
|
|
||
| // GCENodeClassSpec is the top level specification for the GCP Karpenter Provider. | ||
| // This will contain the configuration necessary to launch instances in GCP. | ||
| type GCENodeClassSpec struct { |
There was a problem hiding this comment.
GCE or ce?
https://cloud.google.com/products/compute?hl=en
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
/cc @jwcesign @Vacant2333 @IRONICBo This is the beginning
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?