BUG: Support WeakSets and ABCMeta instances. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TIL weakset was only added in 2.6... |
ssanderson
force-pushed
the
learn-your-abcs
branch
from
1b4fea5 to
9534e1e
Compare
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 81.21% 81.34% +0.13%
==========================================
Files 2 2
Lines 559 563 +4
Branches 112 113 +1
==========================================
+ Hits 454 458 +4
Misses 75 75
Partials 30 30
Continue to review full report at Codecov.
|
Fixes a bug where pickling instances of instances of ABCMeta (you read that correctly) would fail because ABCMeta uses several (previously unpicklable) WeakSets as caches. We fix the issue by adding support for pickling WeakSets via `save_reduce`.
ssanderson
force-pushed
the
learn-your-abcs
branch
from
9534e1e to
3f2964d
Compare
|
Looking good Scott, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where pickling instances of instances of ABCMeta (you read
that correctly) would fail because ABCMeta uses several (previously
unpicklable) WeakSets as caches.
We fix the issue by adding support for pickling WeakSets via
save_reduce.Fixes #103.