Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern maintenance tooling #521

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Oct 13, 2023

  • Run black and ruff on all files via pre-commit (fixes Use black to format the code base #497),
  • Use pyproject.toml (with flit) instead of setup.py for packaging and tool config,
  • Update the CI to reuse the pre-commit setup as PR linter.

@ogrisel ogrisel added the ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects. label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c6f8cd4) 96.07% compared to head (39cae0b) 96.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   96.07%   96.08%   +0.01%     
==========================================
  Files           3        3              
  Lines         560      562       +2     
  Branches      116      116              
==========================================
+ Hits          538      540       +2     
  Misses         11       11              
  Partials       11       11              
Files Coverage Δ
cloudpickle/__init__.py 100.00% <100.00%> (ø)
cloudpickle/cloudpickle_fast.py 100.00% <ø> (ø)
cloudpickle/cloudpickle.py 96.02% <93.61%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ogrisel ogrisel mentioned this pull request Oct 13, 2023
@ogrisel
Copy link
Contributor Author

ogrisel commented Oct 13, 2023

When merging this PR we should rather rebase and merge (or create a merge commit) to be able to include the black commit in .git-blame-ignore-revs.

@ogrisel ogrisel merged commit 21f1445 into cloudpipe:master Oct 13, 2023
20 of 21 checks passed
@ogrisel ogrisel deleted the modern-maintenance-tooling branch October 13, 2023 12:54
@rgbkrk
Copy link
Member

rgbkrk commented Oct 13, 2023

Thank you @ogrisel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use black to format the code base
2 participants