This repository was archived by the owner on Jan 31, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Implementation #1
Initial Implementation #1
Changes from 37 commits
a8ebeb5
6990ce1
a1443ab
15dc1fc
e16471d
43d7c2e
6fc9306
f3381b3
815a2af
8217a04
cc37e9d
703f468
8ea0f6f
90fd5c4
e37c248
93c40a7
efbb2a9
07d5b12
f4d3da6
4e7fca3
8878e8f
ee895eb
5a83a29
f3c1acb
8d9805a
f73c4e0
5af1915
4008913
d5ff200
4604abc
4eb933c
2bb4d2a
7e06728
f457c38
87b1b80
a842894
ab5df7e
862ef60
84c69bc
c66e25d
9bf608d
62e276d
973fe02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goruha This is not needed and will fall back on enabled for the whole module if we don't override a specific service enabled flag like this. It was done like this so we could turn enable/disable individual services if we needed, rather than the entire module enable/disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
terraform-root-modules
I 💯 agree. For this module, I am on the fence.