Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vars sensitive #36

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Make vars sensitive #36

merged 3 commits into from
Mar 10, 2021

Conversation

kevcube
Copy link
Contributor

@kevcube kevcube commented Mar 10, 2021

cloudposse/terraform-aws-ecs-web-app#113 <-- That PR broke this module.

what

  • mark sensitive outputs sensitive

why

  • current module doesn't work with tf 0.14
Error: Output refers to sensitive values

  on outputs.tf line 46:
  46: output "container_definition_json" {

Expressions used in outputs can only refer to sensitive values if the
sensitive attribute is true.


Error: Output refers to sensitive values

  on outputs.tf line 51:
  51: output "container_definition_json_map" {

Expressions used in outputs can only refer to sensitive values if the
sensitive attribute is true.

@kevcube kevcube requested review from a team as code owners March 10, 2021 00:12
@kevcube kevcube requested a review from a team as a code owner March 10, 2021 00:14
@kevcube kevcube requested review from adamcrews and 3h4x March 10, 2021 00:14
@aknysh
Copy link
Contributor

aknysh commented Mar 10, 2021

/test all

@aknysh
Copy link
Contributor

aknysh commented Mar 10, 2021

/rebuild-readme

@aknysh
Copy link
Contributor

aknysh commented Mar 10, 2021

@kevcube thanks for the PR, LGTM.
Can you please push anything to it again to trigger the validate-codeowners GitHub workflow - not sure why it was not triggered before (the trigger is set on any PR actions).
Thanks

@aknysh
Copy link
Contributor

aknysh commented Mar 10, 2021

/test all

@aknysh aknysh merged commit b3364c1 into cloudposse-archives:master Mar 10, 2021
@kevcube kevcube deleted the patch-1 branch March 10, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants