This repository has been archived by the owner on Jan 30, 2021. It is now read-only.
Fix ssm_actions and ssm_resources types #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variables in this modules are lists and should not be define as list in the main.tf file.
Update the code with Terraform syntax >0.12.16.
|
This is one of my first PRs... if I need to do something more, please let me know, I'd be happy to ! |
maximmi
suggested changes
Mar 4, 2020
There was a problem hiding this comment.
@chess-seventh thanks for contribution!
This repo is in our queue to convert to TF 0.12. It is not enough to just replace syntax but we have requirements to cover module with tests. If you want to contribute it in a proper way (see example) you are most welcome! Give it a try, then ping me, so I could review and run tests. This will help us and speed up the process. Otherwise we all have to wait until it will be done as well as many other modules in queue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two variables
var.ssm_actionsandvar.ssm_resourcesare lists. In this modules'main.tfthey where used as lists.This PR fixes this problem and updates the terraform syntax.