Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compile atmos #33

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Cross-compile atmos #33

merged 1 commit into from
Apr 26, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 25, 2021

what

why

  • Make binaries available for other platforms

notes

  • At this time, Windows builds fail due to syscall in k-kinzal/aliases@v0.5.1 being undefined, so we are not yet distributing Windows binaries
  • At this time, builds using go 1.16 fail due to an incompatibility with Variant 0.37.1, so we must use go 1.15 and cannot build binaries for Apple M1 because that requires go 1.16.
  • The preferred way to set the version is by having the go linker set the value of a global variable, but there is no way to reference a global go variable inside a variant job.

references

@Nuru Nuru added the patch A minor, backward compatible change label Apr 25, 2021
@Nuru Nuru requested review from osterman and aknysh April 25, 2021 06:46
@Nuru Nuru requested review from a team as code owners April 25, 2021 06:46
@Nuru Nuru merged commit 9d58bb3 into master Apr 26, 2021
@Nuru Nuru deleted the cross-compile branch April 26, 2021 02:53
@Nuru Nuru mentioned this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants